Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/issue 108 fine grained observability #110

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jan 4, 2023

Related Issue

resolves #108 (very much an early WIP)

demo PR available at thescientist13/greenwood-counter-jsx#3

Summary of Changes

  1. Fine grained observability for basic textContent replacements

TODO

  1. Fine grained observability for Shadow DOM
  2. Attributes
  3. Can it handle things like loops, like a list? (e.g. Todo App)
    • actually, when everything is just "signals" does the initial render matter?
  4. Testing
  5. Documentation
    • JSX expressions must be wrapped in a tag
  6. clean up console logs
  7. (nice to have) Co-mingled interpolations - make it so JSX expressions don't have to be wrapped in DOM elements, e.g.
    // does not work
    <h1>Hello, {greeting}!</h1>
    
    <span class={conditionalClass}>{count}{conditionalText}</span>
    
    // works
    <h1>Hello, <span>{greeting}</span>!</h1>
    
    <span class={conditionalClass}><span>{count}</span>{conditionalText}</span>

@thescientist13 thescientist13 added documentation Improvements or additions to documentation feature New feature or request expirement JSX labels Jan 4, 2023
@thescientist13 thescientist13 self-assigned this Jan 4, 2023
@thescientist13 thescientist13 force-pushed the feature/issue-108-fine-grained-observability branch from 31732b1 to ab02ab7 Compare January 2, 2024 16:44
@thescientist13 thescientist13 changed the title implementing fine grained observability feature/issue 108 implementing fine grained observability Jan 6, 2024
@thescientist13 thescientist13 changed the title feature/issue 108 implementing fine grained observability feature/issue 108 fine grained observability Jan 9, 2024
@thescientist13 thescientist13 force-pushed the feature/issue-108-fine-grained-observability branch from ab02ab7 to 83ea8f1 Compare January 9, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation expirement feature New feature or request JSX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fine Grained Inferred Observability for JSX
1 participant